Repository navigation
fix(acme): apply issuer settings and restore certificate renewal - #307
Merged
Merged
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes aligning ACME issuance and renewal with the configured issuer settings.
No open issues 🎉
What changed in this PR
This PR fixes ACME certificate handling so issuance and renewal use the configured issuer settings consistently.
Changes:
- Replace the default issuer list with the configured ACME issuer.
- Reuse the certificate configuration for cache maintenance and stop maintenance if certificate setup fails.
- Add regression tests for issuer settings and reloading renewed certificates from storage.
| File | Description |
|---|---|
CHANGELOG.md |
Document the ACME issuer and renewal fixes. |
acme/acme.go |
Share configuration between issuance and renewal, apply issuer settings, and clean up on failure. |
acme/acme_test.go |
Test issuer settings and renewed certificate cache updates. |
Review effort: Balanced
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 88.47% 90.05% +1.58%
==========================================
Files 29 29
Lines 1345 1348 +3
==========================================
+ Hits 1190 1214 +24
+ Misses 155 134 -21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
closes: roadrunner-server/roadrunner#2455
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
git commit -s).CHANGELOG.md.